Use precompiled struct methods for pack, unpack data#266
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Apr 5, 2018
Merged
Use precompiled struct methods for pack, unpack data#266brian-brazil merged 1 commit intoprometheus:masterfrom
brian-brazil merged 1 commit intoprometheus:masterfrom
Conversation
brian-brazil
reviewed
Apr 4, 2018
prometheus_client/core.py
Outdated
Contributor
There was a problem hiding this comment.
put an _ in front of these so they aren't exported
brian-brazil
reviewed
Apr 4, 2018
prometheus_client/core.py
Outdated
Contributor
There was a problem hiding this comment.
Explain what you're doing a bit more. Not everyone will have seen the relevant talks by Raymond Hettinger
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I know why this works, but someone reading this code might not. A quick comment will help future readers of the code.
umax
force-pushed
the
struct-usage-improvements
branch
from
223267c to
1b295a7
Compare
umax
force-pushed
the
struct-usage-improvements
branch
from
1b295a7 to
adaad2d
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for struct usage optimizations: https://docs.python.org/2/library/struct.html#classes
Regarding string formatting: